Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tab border customization and Tab header background color #87

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Conversation

xlrod
Copy link
Contributor

@xlrod xlrod commented Nov 26, 2019

Parameters added to New-HTMLTabOptions:

  • Added the -BorderRadius parameter with four options to customize the tab border style (0px, 10px, 15px, 25px) from square to more rounded borders.

  • Added the -BorderBackgroundColor parameter to customize the tab header background color.

  • Added the $Script:BorderStyle variable to the New-HTMLTabHead to apply the styles.

New-HTMLTabOptions -SelectorColor Blue -BorderRadius 0px -BorderBackgroundColor LightBlue

0px

New-HTMLTabOptions -SelectorColor Blue -BorderRadius 10px -BorderBackgroundColor LightBlue

10px

New-HTMLTabOptions -SelectorColor Blue -BorderRadius 15px -BorderBackgroundColor LightBlue

15px

New-HTMLTabOptions -SelectorColor Blue -BorderRadius 25px -BorderBackgroundColor LightBlue

25px

New-HTMLTabOptions -SlimTabs -SelectorColor Blue -BorderRadius 25px -BorderBackgroundColor LightBlue

slim

Adding the `$Script:BorderStyle` variable to customize the Tab borders and Tab header background color.
Added the `-BorderRadius` and `-BorderBackgroundColor` parameters to the `New-HTMLTabOptions` function, to allow the Tab borders to be customized from square to round, as well as the tab header's background color.
@PrzemyslawKlys
Copy link
Member

The tests are failing. Please fix them. It seems like you are copy pasting into GitHub or are you editing in VSCode and committing directly.

I also believe you're deleting fork every time right? You may want to look into learning to work with GitHub. It seems I could use your help ;-)

@xlrod
Copy link
Contributor Author

xlrod commented Nov 26, 2019

I was pasting into the edit page for GitHub. I'm going to learn how to better work with GitHub over the weekend. Thanks!

@PrzemyslawKlys PrzemyslawKlys merged commit b40cfe0 into EvotecIT:master Nov 27, 2019
@PrzemyslawKlys
Copy link
Member

Here's a good overview of how to help with open source projects: https://sqldbawithabeard.com/2019/11/29/how-to-fork-a-github-repository-and-contribute-to-an-open-source-project/

Hope it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants