Fix package not working with Yarn PnP #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necessary as it writes into its own directory
Gankra
added a commit
to axodotdev/cargo-dist
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this package commits the cardinal sin of writing into its own package directory, and Yarn's whole imperative is to nuke bad patterns out of orbit, it doesn't work with Yarn PnP. Therefore, there are two options to get this working:
preferUnplugged: trueand let Yarn extract the package into a disgustingly mutable directory.This PR implements the latter because it took me two seconds.
With this change, Yarn users using PnP should no longer have any issues using rover and should no longer need to run an unplug command manually to get it working. Tada.