-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connect): distinct + sort #3677
feat(connect): distinct + sort #3677
Conversation
CodSpeed Performance ReportMerging #3677 will degrade performances by 32.02%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3677 +/- ##
==========================================
- Coverage 77.85% 75.92% -1.94%
==========================================
Files 729 728 -1
Lines 89983 91440 +1457
==========================================
- Hits 70057 69425 -632
- Misses 19926 22015 +2089
|
…Daft into connect_distinct
…Daft into connect_distinct
…Daft into connect_distinct
let arg = if arg.as_literal().and_then(|lit| lit.as_i32()) == Some(1i32) { | ||
col("*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in spark, df.count()
is processed as count(1)
, which is equivalent to our count(*)
arg | ||
}; | ||
|
||
let count = arg.count(CountMode::All).cast(&DataType::Int64); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spark doesn't support u64's so we need to cast it to i64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could we add a test for count(*) as well?
AFAIK, you can't do |
depends on #3666
see here for proper diff
universalmind303/Daft@error-messages...connect_distinct