-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tpch + tpcds GHA launcher #3619
Conversation
CodSpeed Performance ReportMerging #3619 will improve performances by 50.73%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3619 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 720 720
Lines 88794 88796 +2
=======================================
+ Hits 69252 69258 +6
+ Misses 19542 19538 -4 |
@raunakab It doesn't look like the prompt properly gets printed unless you have a really wide terminal: |
@universalmind303 Oh that's strange. I can throw in an edit there soon. If you want to get by that for now, just type in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing i'm worried about is discovery for this.
I know I'm not going to remember uv run tools/tpcds.py --scale-factor=100 --questions='1-10' --cluster-profile='medium-x86'
does uv have any built in discovery for scripts?
Hmm, that is a good point. This might be something that @samster25 might know about. I'll try to see if something can be fashioned to help with discoverability. |
@universalmind303 Yes, that is a point that I found annoying. I'm currently working on that right now. My current thought is to produce an output CSV file which can be downloaded and viewed. It would list the queries, how long each one took, and any failures observed. |
08879a4
to
5502a2c
Compare
@universalmind303, here is another PR which aims to make the outputs of runs nicer to visualize: #3625. The first run is still running right now, but you should be able to see an output.csv file uploaded to GitHub for you to download and view. The run is here: |
WRT discoverability, once we have more concrete workflows we can start organizing things as https://docs.astral.sh/uv/guides/tools/#running-tools We can probably have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, some comments
Example of successful TPCH run (invoked via Example of successful TPC-DS run (invoked via |
# Overview This PR adds a "tpch" and "tpcds" launcher to the available tools. Allows you to easily scale up a ray-cluster and run queries against it. ## Usage In order to run tpcds, run the following: ```sh uv run tools/tpch.py --scale-factor=2 --num-partitions=2 --questions='1-10' ``` In order to run tpcds, run the following: ```sh uv run tools/tpcds.py --scale-factor=100 --questions='1-10' ``` As always, if you want help, run `uv run tools/tpch.py --help` or `uv run tools/tpcds.py --help`.
Overview
This PR adds a "tpch" and "tpcds" launcher to the available tools. Allows you to easily scale up a ray-cluster and run queries against it.
Usage
In order to run tpcds, run the following:
uv run tools/tpch.py --scale-factor=2 --num-partitions=2 --questions='1-10'
In order to run tpcds, run the following:
uv run tools/tpcds.py --scale-factor=100 --questions='1-10'
As always, if you want help, run
uv run tools/tpch.py --help
oruv run tools/tpcds.py --help
.