Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade pyarrow pin to >=8.0.0 #3612

Merged
merged 4 commits into from
Dec 19, 2024
Merged

chore!: upgrade pyarrow pin to >=8.0.0 #3612

merged 4 commits into from
Dec 19, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 19, 2024

Updates the lower bound of pyarrow to pyarrow>=8.0.0.

This allows us to flatten some code checks.

However, it turns out that our tests aren't being properly skipped -- I had to update the tests to just skip based on our lower bound (skip if version < 9.0.0) which very loose, but otherwise searching for the individual versions for each suite of tests was quite difficult.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #3612 will improve performances by 78.67%

Comparing jay/pyarrow-8 (901e32b) with main (063de4d)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main jay/pyarrow-8 Change
test_iter_rows_first_row[100 Small Files] 304.4 ms 170.4 ms +78.67%

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (5e40837) to head (901e32b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   77.81%   77.23%   -0.58%     
==========================================
  Files         718      717       -1     
  Lines       88249    88791     +542     
==========================================
- Hits        68667    68580      -87     
- Misses      19582    20211     +629     
Files with missing lines Coverage Δ
daft/table/table_io.py 86.47% <100.00%> (-0.17%) ⬇️

... and 27 files with indirect coverage changes

@jaychia jaychia merged commit a76f800 into main Dec 19, 2024
44 checks passed
@jaychia jaychia deleted the jay/pyarrow-8 branch December 19, 2024 08:31
@jaychia jaychia changed the title chore!: upgrade Ray pins and pyarrow pins chore!: upgrade pyarrow pin to >=8.0.0 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant