Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connect): add more tests for createDataFrame #3607

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

@andrewgazelka andrewgazelka marked this pull request as ready for review December 19, 2024 00:48
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #3607 will improve performances by 11.49%

Comparing andrew/test-create-df (e787f68) with main (e0d2b8a)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main andrew/test-create-df Change
test_iter_rows_first_row[100 Small Files] 185.3 ms 166.2 ms +11.49%

@github-actions github-actions bot added the test label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.82%. Comparing base (ca4d3f7) to head (e787f68).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
+ Coverage   77.80%   77.82%   +0.02%     
==========================================
  Files         718      717       -1     
  Lines       88176    87960     -216     
==========================================
- Hits        68607    68459     -148     
+ Misses      19569    19501      -68     

see 7 files with indirect coverage changes

@andrewgazelka andrewgazelka merged commit 7f2d3b1 into main Dec 19, 2024
44 checks passed
@andrewgazelka andrewgazelka deleted the andrew/test-create-df branch December 19, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants