-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add ability to array-ify args and run multiple jobs #3584
Conversation
019d354
to
735b16c
Compare
There are some hardcoded values in the runner script (that is run on the runner node, not the ray-head node). However, we don't have a mechanism to pass values along to the runner script. I'm thinking of creating one named |
CodSpeed Performance ReportMerging #3584 will degrade performances by 37.6%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be generating TPC-DS data for every run-cluster
command.
Not sure what's going on there, also you're generating this on the runner, but we need the data to be available in S3?
Example of a successful run: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3584 +/- ##
==========================================
+ Coverage 77.79% 77.82% +0.02%
==========================================
Files 716 716
Lines 87991 88243 +252
==========================================
+ Hits 68455 68673 +218
- Misses 19536 19570 +34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we point to a successful job run as well?
Example of a successful run (run on just 1 argument, |
Example of a successful run (run on multiple arguments, |
Overview
Previously, the
run-cluster
workflow only ran one ray-job-submission. This PR extends the ability to be able to run any arbitrary array of job submissions by enabling us to pass an array into theentrypoint_args
input param. This then splits the command into its multiple pieces and submits them all.Example Usage
The above invocation runs TPC-DS queries 1 and 2.