Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): df.show #3560

Merged
merged 14 commits into from
Dec 18, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Dec 12, 2024

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #3560 will degrade performances by 17.22%

Comparing universalmind303:connect_show (a79150b) with main (6602502)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:connect_show Change
test_iter_rows_first_row[100 Small Files] 236.5 ms 285.7 ms -17.22%

@andrewgazelka
Copy link
Contributor

andrewgazelka commented Dec 12, 2024

fyi if you make your PRs inside the repository and set the right branch to merge into, you should be able to make the PR show the correct files changed

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (6602502) to head (a79150b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/logical_plan.rs 95.71% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3560      +/-   ##
==========================================
+ Coverage   77.94%   77.96%   +0.02%     
==========================================
  Files         720      720              
  Lines       88480    88550      +70     
==========================================
+ Hits        68962    69035      +73     
+ Misses      19518    19515       -3     
Files with missing lines Coverage Δ
src/daft-connect/src/session.rs 100.00% <ø> (ø)
src/daft-dsl/src/lit.rs 57.22% <100.00%> (+0.93%) ⬆️
src/daft-connect/src/translation/logical_plan.rs 87.78% <95.71%> (+9.09%) ⬆️

... and 5 files with indirect coverage changes

@universalmind303 universalmind303 merged commit ca4d3f7 into Eventual-Inc:main Dec 18, 2024
40 of 41 checks passed
@universalmind303 universalmind303 deleted the connect_show branch January 23, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants