-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swordfish): Enable left/right joins to build probe table on either side #3548
Conversation
CodSpeed Performance ReportMerging #3548 will degrade performances by 12.43%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3548 +/- ##
==========================================
+ Coverage 77.69% 77.80% +0.10%
==========================================
Files 710 716 +6
Lines 86941 87985 +1044
==========================================
+ Hits 67552 68457 +905
- Misses 19389 19528 +139
|
TPCH Sf10 stats:
The biggest win here is Q13 with 48% and Q17 with 98% |
Enable left/right joins to build on either side. E.g. if left join, we can build on left and save used values in a bitmap (same as outer join), then emit the unmatched rows from the finalize.
Total tpch time after this pr: 65s, down from 88s