Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run-cluster-workflow): Add null check when parsing metadata #3507

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Dec 6, 2024

Overview

When parsing a python script's inline metadata, add a null-check if the file contains no metadata.

@github-actions github-actions bot added the fix label Dec 6, 2024
@raunakab raunakab requested a review from jaychia December 6, 2024 17:35
@raunakab raunakab marked this pull request as ready for review December 6, 2024 17:35
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #3507 will improve performances by ×2.2

Comparing fix/inline-metadata (fe27f49) with main (4734c53)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main fix/inline-metadata Change
test_iter_rows_first_row[100 Small Files] 312 ms 144.7 ms ×2.2

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.59%. Comparing base (4734c53) to head (fe27f49).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3507      +/-   ##
==========================================
- Coverage   77.60%   77.59%   -0.01%     
==========================================
  Files         707      707              
  Lines       86174    86172       -2     
==========================================
- Hits        66873    66866       -7     
- Misses      19301    19306       +5     

see 4 files with indirect coverage changes

@raunakab raunakab merged commit 3a8cece into main Dec 6, 2024
43 checks passed
@raunakab raunakab deleted the fix/inline-metadata branch December 6, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants