Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tpcds): fix bugs in tpcds datagen script #3495

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Dec 5, 2024
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #3495 will degrade performances by 29.87%

Comparing universalmind303:fix-tpcds-datagen (061bde2) with main (c2abed8)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:fix-tpcds-datagen Change
test_iter_rows_first_row[100 Small Files] 228.4 ms 325.7 ms -29.87%
test_show[100 Small Files] 23.5 ms 15.7 ms +49.54%

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (3eeba09) to head (061bde2).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3495      +/-   ##
==========================================
+ Coverage   77.38%   77.44%   +0.05%     
==========================================
  Files         699      702       +3     
  Lines       84971    85215     +244     
==========================================
+ Hits        65753    65991     +238     
- Misses      19218    19224       +6     

see 5 files with indirect coverage changes

Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raunakab raunakab enabled auto-merge (squash) December 6, 2024 01:25
@raunakab raunakab changed the title [BUG]: fix tpcds/datagen [BUG]: fix tpcds datagen Dec 6, 2024
@raunakab raunakab changed the title [BUG]: fix tpcds datagen [FIX]: fix tpcds datagen Dec 6, 2024
@raunakab raunakab changed the title [FIX]: fix tpcds datagen [fix]: fix tpcds datagen Dec 6, 2024
@raunakab raunakab changed the title [fix]: fix tpcds datagen fix(tpcds): fix bugs in tpcds datagen script Dec 6, 2024
@github-actions github-actions bot added the fix label Dec 6, 2024
@raunakab raunakab merged commit 8009155 into Eventual-Inc:main Dec 6, 2024
42 of 46 checks passed
@universalmind303 universalmind303 deleted the fix-tpcds-datagen branch January 23, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants