[BUG] Remove enum imports from match statements

[raunakab]

Overview

Importing enums is extremely bad style in Rust. This can lead to nasty errors in the future when enum definitions change.

Please stop doing this.

[andrewgazelka]

hooray I agree 🕺

[raunakab]

hooray I agree 🕺

@andrewgazelka This is a large problem in our codebase. I will (in the future) start merging in small, piecemeal PRs to address this issue.

[codspeed-hq]

CodSpeed Performance Report

Merging #3436 will improve performances by ×2.1

_{Comparing bug/remove-enum-imports (0ab08e4) with main (3ece13a)}

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	bug/remove-enum-imports	Change
⚡	test_show[100 Small Files]	31.9 ms	14.9 ms	×2.1

[andrewgazelka]

hooray I agree 🕺

@andrewgazelka This is a large problem in our codebase. I'm going to start merging in small, piecemeal PRs to address this issue.

Do we want to prio this though?

BigDaft

ideally if we want to enforce something should also add to clippy lints
https://rust-lang.github.io/rust-clippy/master/index.html

[raunakab]

hooray I agree 🕺

@andrewgazelka This is a large problem in our codebase. I'm going to start merging in small, piecemeal PRs to address this issue.

Do we want to prio this though?

BigDaft

ideally if we want to enforce something should also add to clippy lints https://rust-lang.github.io/rust-clippy/master/index.html

Probably not right now, but in the future.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (3ece13a) to head (0ab08e4).
Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3436   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files         684      684           
  Lines       83637    83637           
=======================================
  Hits        64694    64694           
  Misses      18943    18943           

see 1 file with indirect coverage changes