Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: sql HAVING #3364

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 20, 2024
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #3364 will improve performances by 83.54%

Comparing universalmind303:sql-having (b011517) with main (bdfb8c6)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main universalmind303:sql-having Change
test_iter_rows_first_row[100 Small Files] 362 ms 197.2 ms +83.54%
test_show[100 Small Files] 33 ms 23.8 ms +38.76%

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.42%. Comparing base (b89ee3d) to head (413b906).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
- Coverage   77.42%   77.42%   -0.01%     
==========================================
  Files         678      678              
  Lines       83213    83234      +21     
==========================================
+ Hits        64431    64444      +13     
- Misses      18782    18790       +8     
Files with missing lines Coverage Δ
src/daft-sql/src/planner.rs 70.64% <100.00%> (+0.43%) ⬆️

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some test requests

tests/sql/test_aggs.py Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) November 20, 2024 20:32
@universalmind303 universalmind303 merged commit b6695eb into Eventual-Inc:main Nov 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants