Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): read/write → csv, write → json #3361

Merged
merged 1 commit into from
Dec 19, 2024

[FEAT] connect: read/write -> csv, write -> json

59c7803
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): read/write → csv, write → json #3361

[FEAT] connect: read/write -> csv, write -> json
59c7803
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 1s

77.84% (+0.03%) compared to ea8f8bd

View this Pull Request on Codecov

77.84% (+0.03%) compared to ea8f8bd

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.84%. Comparing base (ea8f8bd) to head (59c7803).

Files with missing lines Patch % Lines
...t/src/translation/logical_plan/read/data_source.rs 71.42% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
+ Coverage   77.80%   77.84%   +0.03%     
==========================================
  Files         718      718              
  Lines       88247    88250       +3     
==========================================
+ Hits        68662    68698      +36     
+ Misses      19585    19552      -33     
Files with missing lines Coverage Δ
src/daft-connect/src/op/execute/write.rs 80.00% <100.00%> (+1.95%) ⬆️
...t/src/translation/logical_plan/read/data_source.rs 81.08% <71.42%> (-3.30%) ⬇️

... and 4 files with indirect coverage changes