Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add drop support #3345

Merged
merged 2 commits into from
Dec 11, 2024

remove usage of pandas

a2b6e59
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): add drop support #3345

remove usage of pandas
a2b6e59
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 0s

77.78% (+0.00%) compared to 5238279

View this Pull Request on Codecov

77.78% (+0.00%) compared to 5238279

Details

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (5238279) to head (a2b6e59).

Files with missing lines Patch % Lines
.../daft-connect/src/translation/logical_plan/drop.rs 92.30% 2 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3345   +/-   ##
=======================================
  Coverage   77.77%   77.78%           
=======================================
  Files         715      716    +1     
  Lines       87695    87724   +29     
=======================================
+ Hits        68207    68233   +26     
- Misses      19488    19491    +3     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 68.96% <66.66%> (-0.13%) ⬇️
.../daft-connect/src/translation/logical_plan/drop.rs 92.30% <92.30%> (ø)

... and 2 files with indirect coverage changes