-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Implement deserialize for Python objects serialized as sequences #3339
Conversation
CodSpeed Performance ReportMerging #3339 will degrade performances by 52.79%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 77.37% 77.17% -0.20%
==========================================
Files 677 678 +1
Lines 82864 83228 +364
==========================================
+ Hits 64113 64235 +122
- Misses 18751 18993 +242
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but should we really be using JSON as the serde mechanism instead of bytes?
I had this question too, but we can address that later. @samster25 wrote the IO Config pickling so maybe he should know the rationale. |
I did |
@kevinzwang maybe good as a quick follow-up to switch us to using bytes |
#3400 PTAL! |
visit_seq
is used when using serde_json to serialize/deserialize Rust objects, since the byte buffer is just stored as a list of numbers in JSON.