Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Fix join alias test #3335

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[CHORE] Fix join alias test #3335

merged 1 commit into from
Nov 19, 2024

Conversation

kevinzwang
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #3335 will improve performances by 41.34%

Comparing kevin/fix-join-alias-test (51fbe57) with main (25304eb)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main kevin/fix-join-alias-test Change
test_show[100 Small Files] 33.1 ms 23.4 ms +41.34%

@kevinzwang kevinzwang merged commit a9bf7c0 into main Nov 19, 2024
42 checks passed
@kevinzwang kevinzwang deleted the kevin/fix-join-alias-test branch November 19, 2024 22:52
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.14%. Comparing base (dab006f) to head (51fbe57).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
- Coverage   77.32%   77.14%   -0.19%     
==========================================
  Files         677      677              
  Lines       82810    83479     +669     
==========================================
+ Hits        64035    64400     +365     
- Misses      18775    19079     +304     

see 14 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants