Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: tbl alias with join #3333

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

universalmind303
Copy link
Contributor

closes #3311

@github-actions github-actions bot added the bug Something isn't working label Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #3333 will degrade performances by 41.38%

Comparing universalmind303:tbl-alias-bug (537919a) with main (1b84250)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:tbl-alias-bug Change
test_show[100 Small Files] 24.1 ms 41.2 ms -41.38%

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (824df2c) to head (537919a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-sql/src/planner.rs 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3333      +/-   ##
==========================================
- Coverage   77.38%   77.32%   -0.07%     
==========================================
  Files         676      677       +1     
  Lines       82604    82808     +204     
==========================================
+ Hits        63926    64029     +103     
- Misses      18678    18779     +101     
Files with missing lines Coverage Δ
src/daft-sql/src/planner.rs 68.03% <75.00%> (-0.03%) ⬇️

... and 9 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@universalmind303 universalmind303 merged commit dab006f into Eventual-Inc:main Nov 19, 2024
40 of 42 checks passed
@ukclivecox
Copy link

Thanks!

@universalmind303 universalmind303 deleted the tbl-alias-bug branch January 23, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: aliases cause error if one is prefix of another: FieldNotFound error
3 participants