-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE]: prepare for nulls first/last kernels #3301
[CHORE]: prepare for nulls first/last kernels #3301
Conversation
CodSpeed Performance ReportMerging #3301 will improve performances by 67.12%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
- Coverage 77.59% 77.31% -0.29%
==========================================
Files 668 678 +10
Lines 82211 83063 +852
==========================================
+ Hits 63793 64218 +425
- Misses 18418 18845 +427
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
This pr adds nulls_first to all sort functions in preparation for implementing the nulls first/last kernels. This will be followed up by adding the actual nulls first/last implementations.