Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Lance writes for swordfish #3299

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[FEAT] Lance writes for swordfish #3299

merged 1 commit into from
Nov 15, 2024

Conversation

colin-ho
Copy link
Contributor

This PR implements Lance writes for swordfish.

The scaffolding for writes was merged in: #2992, and so this one simply adds the lance writes functionality.

@github-actions github-actions bot added the enhancement New feature or request label Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #3299 will degrade performances by 29.77%

Comparing colin/swordfish-lance (a208770) with main (711e862)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main colin/swordfish-lance Change
test_count[1 Small File] 3.6 ms 4 ms -10.58%
test_show[100 Small Files] 22.3 ms 31.7 ms -29.77%

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.52%. Comparing base (c4e1ab2) to head (a208770).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3299      +/-   ##
==========================================
+ Coverage   77.50%   77.52%   +0.02%     
==========================================
  Files         666      667       +1     
  Lines       81333    81424      +91     
==========================================
+ Hits        63036    63128      +92     
+ Misses      18297    18296       -1     
Files with missing lines Coverage Δ
src/daft-local-execution/src/pipeline.rs 95.45% <100.00%> (+0.15%) ⬆️
src/daft-local-execution/src/sinks/write.rs 100.00% <100.00%> (ø)
src/daft-local-plan/src/plan.rs 96.57% <100.00%> (+0.18%) ⬆️
src/daft-local-plan/src/translate.rs 93.90% <100.00%> (+0.31%) ⬆️
src/daft-writers/src/catalog.rs 92.72% <ø> (ø)
src/daft-writers/src/lance.rs 100.00% <100.00%> (ø)
src/daft-writers/src/lib.rs 96.07% <ø> (ø)
src/daft-writers/src/physical.rs 85.71% <100.00%> (ø)
src/daft-writers/src/pyarrow.rs 99.38% <ø> (ø)

... and 1 file with indirect coverage changes

@colin-ho colin-ho merged commit 5c00dbc into main Nov 15, 2024
43 of 44 checks passed
@colin-ho colin-ho deleted the colin/swordfish-lance branch November 15, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants