-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Check env in benchmarking script #3297
Conversation
CodSpeed Performance ReportMerging #3297 will degrade performances by 47.65%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3297 +/- ##
==========================================
- Coverage 77.50% 77.50% -0.01%
==========================================
Files 666 666
Lines 81335 81333 -2
==========================================
- Hits 63041 63036 -5
- Misses 18294 18297 +3 |
@@ -212,7 +222,7 @@ def warmup_environment(requirements: str | None, parquet_folder: str): | |||
"""Performs necessary setup of Daft on the current benchmarking environment""" | |||
ctx = daft.context.get_context() | |||
|
|||
if ctx.get_or_create_runner().name == "ray": | |||
if get_daft_benchmark_runner_name() == "ray": | |||
runtime_env = get_ray_runtime_env(requirements) | |||
|
|||
ray.init( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ray runner gets initialized in get_or_create_runner()
, which calls ray.init
, so the subsequent ray.init
errors.
Using
ctx.get_or_create_runner
in benchmarking warmup code / metrics builder causes subsequentray.inits
to crash. Just check theDAFT_RUNNER
environment var instead, which should be set.Tested: