-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Partially qualified joins join a.x = y
and join x = b.y
#3290
[BUG] Partially qualified joins join a.x = y
and join x = b.y
#3290
Conversation
CodSpeed Performance ReportMerging #3290 will degrade performances by 23.56%Comparing Summary
Benchmarks breakdown
|
…ially-qualified-joins
…ially-qualified-joins
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
=======================================
Coverage 77.50% 77.50%
=======================================
Files 666 666
Lines 81326 81358 +32
=======================================
+ Hits 63029 63059 +30
- Misses 18297 18299 +2
|
…ially-qualified-joins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small comment
previously we only supported either fully qualified
a.x = b.y
or no qualifiersx = y
. this PR fixes this so we can use any combination of fully and partially qualified:so all of the following combinations are now supported.
x = y
x = b.y
y = x
y = a.x
a.x = y
a.x = b.y
b.y = x
b.y = a.x