Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Partially qualified joins join a.x = y and join x = b.y #3290

Merged

Conversation

universalmind303
Copy link
Contributor

previously we only supported either fully qualified a.x = b.y or no qualifiers x = y. this PR fixes this so we can use any combination of fully and partially qualified:
so all of the following combinations are now supported.

  • x = y
  • x = b.y
  • y = x
  • y = a.x
  • a.x = y
  • a.x = b.y
  • b.y = x
  • b.y = a.x

@github-actions github-actions bot added the bug Something isn't working label Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #3290 will degrade performances by 23.56%

Comparing universalmind303:partially-qualified-joins (a53da24) with main (4470192)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:partially-qualified-joins Change
test_show[100 Small Files] 32 ms 41.9 ms -23.56%

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (0720ffc) to head (0dc0e1f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-sql/src/planner.rs 84.74% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3290   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files         666      666           
  Lines       81326    81358   +32     
=======================================
+ Hits        63029    63059   +30     
- Misses      18297    18299    +2     
Files with missing lines Coverage Δ
src/daft-sql/src/planner.rs 69.17% <84.74%> (+0.23%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small comment

src/daft-sql/src/planner.rs Outdated Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) November 15, 2024 01:01
@universalmind303 universalmind303 merged commit 88bf83f into Eventual-Inc:main Nov 15, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants