Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Fix style in workflow file #3284

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[CHORE] Fix style in workflow file #3284

merged 1 commit into from
Nov 13, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Nov 13, 2024

No description provided.

@jaychia jaychia enabled auto-merge (squash) November 13, 2024 18:31
@github-actions github-actions bot added the chore label Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #3284 will degrade performances by 19.26%

Comparing jay/fix-style (73e47cd) with main (769ec98)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jay/fix-style Change
test_count[1 Small File] 3.9 ms 3.5 ms +13.15%
test_iter_rows_first_row[100 Small Files] 340.9 ms 293.8 ms +16.01%
test_show[100 Small Files] 41.3 ms 51.2 ms -19.26%

@jaychia jaychia merged commit 93c7868 into main Nov 13, 2024
41 of 42 checks passed
@jaychia jaychia deleted the jay/fix-style branch November 13, 2024 18:50
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (769ec98) to head (73e47cd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3284      +/-   ##
==========================================
+ Coverage   76.95%   77.69%   +0.73%     
==========================================
  Files         666      666              
  Lines       82264    81131    -1133     
==========================================
- Hits        63309    63037     -272     
+ Misses      18955    18094     -861     

see 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants