Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Possibility to create environment with system installed uv #3281

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

maruschin
Copy link
Contributor

I encountered an inconvenient dependency on a pre-installed version of Python.
It is very convenient to create an environment with the required version via uv.

@maruschin maruschin changed the title Possibility to create environment with preset uv [CHORE] Possibility to create environment with preset uv Nov 13, 2024
@github-actions github-actions bot added the chore label Nov 13, 2024
@maruschin maruschin changed the title [CHORE] Possibility to create environment with preset uv [CHORE] Possibility to create environment with system installed uv Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #3281 will degrade performances by 13.17%

Comparing maruschin:main (6ada75b) with main (5115c32)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main maruschin:main Change
test_iter_rows_first_row[100 Small Files] 260.7 ms 193.4 ms +34.76%
test_show[100 Small Files] 42.4 ms 48.8 ms -13.17%

@jaychia
Copy link
Contributor

jaychia commented Nov 13, 2024

IIUC this PR means that instead of:

  • uv-managed Python with a uv-managed Python environment

We now allow for:

  • system-managed Python that has uv installed, with a uv-managed Python environment

I'm not the most familiar with uv, but would it not be the most reproducible developer experience if uv were to manage everything, including the Python installation? I know we've had issues in the past with inconsistent system installs of Python.

@maruschin
Copy link
Contributor Author

@jaychia it's most like:

  • system-installed uv managed Python and Python environment

uv does not depend on Python and can be installed on its own.

@jaychia jaychia merged commit 711e862 into Eventual-Inc:main Nov 14, 2024
42 of 44 checks passed
@jaychia
Copy link
Contributor

jaychia commented Nov 14, 2024

Makes sense, thanks for the contribution!

Makefile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants