Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Set canonical link #3269

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[DOCS] Set canonical link #3269

merged 1 commit into from
Nov 12, 2024

Conversation

desmondcheongzx
Copy link
Contributor

We should set the canonical link for Daft docs so that google does not index old versions of our docs.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 12, 2024
@desmondcheongzx desmondcheongzx enabled auto-merge (squash) November 12, 2024 03:24
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3269 will degrade performances by 30.69%

Comparing desmondcheongzx:canonical-link (54fb41f) with main (7e89850)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main desmondcheongzx:canonical-link Change
❌ test_iter_rows_first_row[100 Small Files] 226.7 ms 327 ms -30.69%

@desmondcheongzx desmondcheongzx merged commit c77cfdb into Eventual-Inc:main Nov 12, 2024
39 of 40 checks passed
@desmondcheongzx desmondcheongzx deleted the canonical-link branch November 12, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@desmondcheongzx