-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add initial Spark Connect support #3261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3261 will degrade performances by 34.58%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3261 +/- ##
==========================================
+ Coverage 76.07% 77.78% +1.70%
==========================================
Files 644 650 +6
Lines 81581 80350 -1231
==========================================
+ Hits 62065 62501 +436
+ Misses 19516 17849 -1667
|
universalmind303
approved these changes
Nov 11, 2024
andrewgazelka
changed the title
[FEAT] daft-connect add config option
[FEAT] Add initial Spark Connect support
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements basic Spark Connect functionality in Daft with the following:
daft-connect
crate to handle Spark Connect protocolconnect_start()
functionCurrently supports:
Notable changes:
spark-connect
protocoltracing
for debugging and monitoringSome operations like execute_plan, analyze_plan, and artifact handling are
currently unimplemented and will return appropriate error messages.