Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix typo in write_parquet's parameters #3252

Conversation

desmondcheongzx
Copy link
Contributor

Should be write_mode not mode.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 8, 2024
@desmondcheongzx desmondcheongzx enabled auto-merge (squash) November 8, 2024 21:31
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #3252 will degrade performances by 50.76%

Comparing desmondcheongzx:fix-typo-in-write-parquet-docs (6942d95) with main (54e58df)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main desmondcheongzx:fix-typo-in-write-parquet-docs Change
test_show[100 Small Files] 33.1 ms 67.2 ms -50.76%

@desmondcheongzx desmondcheongzx merged commit e27e2f5 into Eventual-Inc:main Nov 8, 2024
39 of 40 checks passed
@desmondcheongzx desmondcheongzx deleted the fix-typo-in-write-parquet-docs branch November 8, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant