-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Streaming Catalog Writes #3160
Conversation
CodSpeed Performance ReportMerging #3160 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3160 +/- ##
==========================================
+ Coverage 78.66% 79.13% +0.47%
==========================================
Files 634 637 +3
Lines 78175 77944 -231
==========================================
+ Hits 61496 61682 +186
+ Misses 16679 16262 -417
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just have a few small things that can be cleaned up
Implements streaming Iceberg and Delta writes for swordfish. Most of the write scaffolding has already been implemented in #2992, this PR implements the Iceberg/Delta specific functionalities.
A quick TLDR on swordfish writes:
daft-writer
crate.Notes:
add_missing_columns
stuff an explicit projection. It was a lil cleaner this way instead of having swordfish implementadd_missing_columns
internally.