Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] implement mean and stddev for decimal #3159

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Oct 31, 2024

closes: #3157

@github-actions github-actions bot added the chore label Oct 31, 2024
Copy link

codspeed-hq bot commented Nov 1, 2024

CodSpeed Performance Report

Merging #3159 will degrade performances by 16.11%

Comparing sammy/decimal-aggs (f903caf) with main (6e28b3f)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sammy/decimal-aggs Change
test_iter_rows_first_row[100 Small Files] 306.5 ms 262.4 ms +16.77%
test_show[100 Small Files] 50.1 ms 59.8 ms -16.11%

@samster25 samster25 marked this pull request as ready for review November 4, 2024 00:59
@samster25 samster25 enabled auto-merge (squash) November 8, 2024 00:42
@samster25 samster25 merged commit 95168fd into main Nov 8, 2024
41 of 42 checks passed
@samster25 samster25 deleted the sammy/decimal-aggs branch November 8, 2024 00:59
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 67.19577% with 62 lines in your changes missing coverage. Please review.

Project coverage is 79.10%. Comparing base (6e28b3f) to head (f903caf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-dsl/src/functions/agg/mod.rs 57.53% 31 Missing ⚠️
src/daft-core/src/datatypes/agg_ops.rs 62.85% 13 Missing ⚠️
src/daft-core/src/datatypes/infer_datatype.rs 47.36% 10 Missing ⚠️
src/daft-core/src/series/ops/agg.rs 73.33% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   79.12%   79.10%   -0.03%     
==========================================
  Files         641      642       +1     
  Lines       78151    78294     +143     
==========================================
+ Hits        61837    61931      +94     
- Misses      16314    16363      +49     
Files with missing lines Coverage Δ
src/daft-core/src/array/iterator.rs 100.00% <ø> (ø)
src/daft-core/src/array/ops/mean.rs 100.00% <100.00%> (ø)
src/daft-core/src/datatypes/mod.rs 40.00% <ø> (ø)
src/daft-dsl/src/expr/mod.rs 78.07% <100.00%> (+0.13%) ⬆️
src/daft-dsl/src/functions/mod.rs 84.21% <ø> (ø)
src/daft-functions/src/list/mean.rs 61.76% <100.00%> (ø)
...ft-physical-plan/src/physical_planner/translate.rs 95.59% <100.00%> (+0.01%) ⬆️
src/daft-core/src/series/ops/agg.rs 77.14% <73.33%> (-0.50%) ⬇️
src/daft-core/src/datatypes/infer_datatype.rs 81.53% <47.36%> (ø)
src/daft-core/src/datatypes/agg_ops.rs 72.91% <62.85%> (-27.09%) ⬇️
... and 1 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement mean and stddev for Decimal128
2 participants