Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add rust cache to s3 build artifacts action #3144

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[CHORE] Add rust cache to s3 build artifacts action #3144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-artifact-s3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ jobs:
with:
submodules: true
fetch-depth: 0
- uses: Swatinem/rust-cache@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may not do anything since the build happens in a docker container for the messense/maturin-action step

We should check if the target dir is volume mounted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should prob use sccache instead

PyO3/maturin-action#53

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try turning on the sccache option for the messense/maturin-action step seen here:

https://github.com/PyO3/maturin-action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol yeah I was literally looking at this as you posted and saw the notification come up on the maturin-action issue 😂 . Going to try sccache

with:
key: ${{ runner.os }}-build-artifact-s3
cache-all-crates: 'true'
- name: Assume GitHub Actions AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
Loading