Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable explode for swordfish #3077

Merged
merged 4 commits into from
Oct 23, 2024
Merged

[FEAT] Enable explode for swordfish #3077

merged 4 commits into from
Oct 23, 2024

Conversation

colin-ho
Copy link
Contributor

Adds explode as an intermediate operator. Unskips all the explode tests

@github-actions github-actions bot added the enhancement New feature or request label Oct 18, 2024
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #3077 will not alter performance

Comparing colin/explode (945a0c7) with main (0727dc1)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (0727dc1) to head (945a0c7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-physical-plan/src/local_plan.rs 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3077   +/-   ##
=======================================
  Coverage   78.64%   78.65%           
=======================================
  Files         617      618    +1     
  Lines       73155    73190   +35     
=======================================
+ Hits        57530    57564   +34     
- Misses      15625    15626    +1     
Files with missing lines Coverage Δ
...ft-local-execution/src/intermediate_ops/explode.rs 100.00% <100.00%> (ø)
src/daft-local-execution/src/pipeline.rs 94.40% <100.00%> (+0.09%) ⬆️
src/daft-physical-plan/src/translate.rs 97.85% <100.00%> (+0.11%) ⬆️
src/daft-physical-plan/src/local_plan.rs 96.03% <92.85%> (-0.21%) ⬇️

@colin-ho colin-ho requested review from jaychia and desmondcheongzx and removed request for jaychia October 18, 2024 21:57
Copy link
Contributor

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@colin-ho colin-ho enabled auto-merge (squash) October 23, 2024 01:40
@colin-ho colin-ho merged commit d1b06fb into main Oct 23, 2024
40 checks passed
@colin-ho colin-ho deleted the colin/explode branch October 23, 2024 01:57
@colin-ho colin-ho restored the colin/explode branch October 23, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants