Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add proper robots.txt and sitemap.xml to index only latest and stable #1752

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 20, 2023

@jaychia jaychia added the documentation Improvements or additions to documentation label Dec 20, 2023
@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe only issue is that we use the getdaft.io domain for other things too besides the docs https://www.getdaft.io/
the current sitemap in this PR would prevent that stuff from getting indexed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a07b301) 85.12% compared to head (39e8e8e) 85.03%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   85.12%   85.03%   -0.10%     
==========================================
  Files          55       55              
  Lines        5518     5518              
==========================================
- Hits         4697     4692       -5     
- Misses        821      826       +5     

see 4 files with indirect coverage changes

@jaychia jaychia merged commit 03f6dac into main Dec 20, 2023
41 of 42 checks passed
@jaychia jaychia deleted the jay/docs-robots branch December 20, 2023 08:11
jaychia added a commit that referenced this pull request Dec 20, 2023
jaychia added a commit that referenced this pull request Dec 20, 2023
…test and stable" (#1753)

Reverts #1752

The proper fix needs to be written to this repo instead:
https://github.com/Eventual-Inc/getdaft.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants