[BUG] Propagate URL download expressions max_connections to S3Config #1708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: URL downloads had a regression when the default value on
S3Config
changed from 64 to 8.This is because our URL download's
max_connections
parameter acts as a "throttling" mechanism for the maximum number of tasks in-flight from a channel buffer.However, if this number is higher than the S3 client's max_connections, then it has no effect since the total number of connections to S3 is capped at
S3Config.max_connections * num_threads
.In this PR, we just override the
S3Config
's value with the one that is passed into the expression.