Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] enable refresh on tqdm total updates #1654

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Nov 21, 2023

  • We currently were only using a background thread when updating the done tasks. Now we also check if new tasks are enqueued to perform a refresh.

@github-actions github-actions bot added the chore label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #1654 (2b9c67c) into main (ea19d28) will increase coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
+ Coverage   84.88%   84.94%   +0.05%     
==========================================
  Files          55       55              
  Lines        5287     5293       +6     
==========================================
+ Hits         4488     4496       +8     
+ Misses        799      797       -2     
Files Coverage Δ
daft/runners/progress_bar.py 80.85% <83.33%> (+0.36%) ⬆️

... and 1 file with indirect coverage changes

@samster25 samster25 merged commit aaf279e into main Nov 21, 2023
40 of 41 checks passed
@samster25 samster25 deleted the sammy/enable-refresh-on-tqdm-total branch November 21, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant