Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] raise error if non valid parquet file (less than parquet footer size) #1628

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[BUG] raise error if non valid parquet file (less than parquet footer size) #1628

merged 2 commits into from
Nov 17, 2023

Conversation

samster25
Copy link
Member

No description provided.

@samster25 samster25 requested a review from jaychia November 17, 2023 05:15
@github-actions github-actions bot added the bug Something isn't working label Nov 17, 2023
jaychia
jaychia approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@samster25 samster25 enabled auto-merge (squash) November 17, 2023 05:17
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b88cc8f). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage        ?   84.86%           
=======================================
  Files           ?       55           
  Lines           ?     5274           
  Branches        ?        0           
=======================================
  Hits            ?     4476           
  Misses          ?      798           
  Partials        ?        0

@samster25 samster25 merged commit a7bd5ec into main Nov 17, 2023
39 checks passed
@samster25 samster25 deleted the sammy/raise-error-if-nonvalid-parquet branch November 17, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaychia jaychia jaychia approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samster25 @jaychia