Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Self-concat breaks with the RayRunner #1617

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Nov 16, 2023

Problem: when performing a dataframe concat with itself, our RayRunner will break on a .wait() call which waits on some duplicate object IDs

@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1617 (7267527) into main (c4b498a) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   84.59%   84.60%           
=======================================
  Files          54       54           
  Lines        5201     5202    +1     
=======================================
+ Hits         4400     4401    +1     
  Misses        801      801           
Files Coverage Δ
daft/runners/ray_runner.py 89.82% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@jaychia jaychia merged commit b78ed32 into main Nov 16, 2023
37 checks passed
@jaychia jaychia deleted the jay/self-concat-bug branch November 16, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant