Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] enable fixed size binary ingest to daft binary #1612

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Nov 16, 2023

  • Enables reads of fixed sized binary data
  • I hit some issues reading UUIDs from parquet files

@samster25 samster25 changed the title enable fixed size binary ingest to daft binary [BUG] enable fixed size binary ingest to daft binary Nov 16, 2023
@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2023
@samster25 samster25 requested a review from jaychia November 16, 2023 01:50
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1612 (77a2c8a) into main (6abc006) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
- Coverage   84.65%   84.59%   -0.06%     
==========================================
  Files          54       54              
  Lines        5201     5201              
==========================================
- Hits         4403     4400       -3     
- Misses        798      801       +3     
Files Coverage Δ
daft/datatype.py 91.98% <100.00%> (ø)

... and 1 file with indirect coverage changes

@samster25 samster25 merged commit 7149083 into main Nov 16, 2023
40 of 41 checks passed
@samster25 samster25 deleted the sammy/enable-fixed-size-binary-ingest branch November 16, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant