Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CustomProperty and CustomProperties method to StreamMetadata #179

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Add CustomProperty and CustomProperties method to StreamMetadata #179

merged 2 commits into from
Jun 5, 2024

Conversation

w1am
Copy link
Contributor

@w1am w1am commented Jun 5, 2024 •
edited
Loading

Added: Add CustomProperty and CustomProperties method to StreamMetadata

Fixes #178

@w1am w1am force-pushed the w1am/add-missing-custom-properties-getter-in-stream-metadata branch from b19b41f to 8c1ebaa Compare June 5, 2024 12:36
@w1am w1am force-pushed the w1am/add-missing-custom-properties-getter-in-stream-metadata branch from 8c1ebaa to 7dc3a1d Compare June 5, 2024 12:47
YoEight
YoEight requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@YoEight YoEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a method that returns all custom properties.

@w1am w1am requested a review from YoEight June 5, 2024 14:20
@w1am w1am changed the title Add CustomProperty method to StreamMetadata Add CustomProperty and CustomProperties method to StreamMetadata Jun 5, 2024
@YoEight YoEight merged commit 7b42179 into master Jun 5, 2024
36 checks passed
@YoEight YoEight deleted the w1am/add-missing-custom-properties-getter-in-stream-metadata branch June 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoEight YoEight YoEight approved these changes

@josephcummings josephcummings josephcummings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing getter for custom properties on StreamMetadata
3 participants
@w1am @YoEight @josephcummings