Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Grpc.Core for netcoreapp3.1 and net48 #93

Merged
merged 21 commits into from
Jan 21, 2021
Merged

Use Grpc.Core for netcoreapp3.1 and net48 #93

merged 21 commits into from
Jan 21, 2021

Conversation

thefringeninja
Copy link
Contributor

@thefringeninja thefringeninja commented Dec 31, 2020 •
edited
Loading

Added: net48 and net5.0 support
Changed: netcoreapp3.1 runs on Grpc.Core

Closes: EventStore/EventStore#2707
Closes: #94

@thefringeninja thefringeninja self-assigned this Dec 31, 2020
@thefringeninja thefringeninja marked this pull request as draft December 31, 2020 09:42
@thefringeninja
Copy link
Contributor Author

See grpc/grpc-dotnet#1158

@thefringeninja thefringeninja force-pushed the net-flamework-4.8 branch 10 times, most recently from e409d56 to fe48b73 Compare January 6, 2021 22:34
@thefringeninja thefringeninja marked this pull request as ready for review January 7, 2021 06:53
@thefringeninja thefringeninja force-pushed the net-flamework-4.8 branch 8 times, most recently from b1e4f7d to 060c1ba Compare January 11, 2021 09:23
@thefringeninja
dual target netcoreapp3.1 and net5.0
3738f84
@thefringeninja
add gossip support to grpc.core implementation
27ba7fc
@thefringeninja
update scan vulnerabilities tool
fe45d52
@thefringeninja
use channel per node for grpc.core implementations
06aad41
@thefringeninja
add net48 support
1e913d1
@thefringeninja
remove/obsolete createHttpMessageHandler
9672b43
@thefringeninja
add reasonable timeouts to gh action jobs
3ad6b3c
@thefringeninja
await ack/nack in tests to avoid 'Only one write can be pending at a …
a2d45b8 
…time'
@thefringeninja
grpc.core may use unavailable instead of deadline exceeded
567f80d
@thefringeninja
include framework in test results file names
3489103
@thefringeninja
skip installing frameworks for targets that don't need it
38774a3
@thefringeninja
implement DisposeAsync for better cleanup
8ea4c58
@thefringeninja
support keep alives
a19d48e
@thefringeninja
skip flakey regression on net .framework
92804a7
@thefringeninja
downgrade to gRPC 2.32.1
3b75d24 
until grpc/grpc#24935 is resolved
@thefringeninja
added dns name to generated certificates
9d24daa
@thefringeninja
remove unused test project
f73f2c1
@thefringeninja
improve array shuffling
18ba7c9
@thefringeninja
obsolete GossipOverHttps
57b5f23
@shaan1337 shaan1337 mentioned this pull request Jan 20, 2021
Closed
shaan1337
shaan1337 previously approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefringeninja great work!

@hayley-jean hayley-jean merged commit 900719c into EventStore:master Jan 21, 2021
@thefringeninja thefringeninja deleted the net-flamework-4.8 branch February 2, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaan1337 shaan1337 shaan1337 approved these changes

@hayley-jean hayley-jean hayley-jean approved these changes

Assignees

@thefringeninja thefringeninja

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@thefringeninja @hayley-jean @shaan1337