-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StreamRevision Updates #53
Conversation
@@ -23,6 +23,7 @@ namespace EventStore.Client { | |||
_value = value; | |||
} | |||
|
|||
public StreamRevision Next() => this + 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to guard ulong.MaxValue + 1
? You could do something like this:
if (_value == ulong.MaxValue) then throw new InvalidOperationException("StreamRevision.None does not have a next value.");
return this + 1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ba57527
to
9c7fb20
Compare
This requires rebase after the recent merge @thefringeninja but looks good otherwise. |
9c7fb20
to
d4848af
Compare
Changed: Convert from StreamPosition to StreamRevision; StreamRevision on IWriteResult