Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gRPC Auth Pipeline Instead of Metadata #52

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Use gRPC Auth Pipeline Instead of Metadata #52

merged 1 commit into from
Jul 1, 2020

Conversation

thefringeninja
Copy link
Contributor

Added: Callback to get authorization header from UserCredentials

@thefringeninja thefringeninja self-assigned this Jun 29, 2020
shaan1337
shaan1337 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Tested with different credentials and working as expected on both a single node/cluster.

@shaan1337 shaan1337 merged commit 540fd9f into EventStore:master Jul 1, 2020
@thefringeninja thefringeninja deleted the channel-options branch July 3, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgermishuys pgermishuys pgermishuys approved these changes

@shaan1337 shaan1337 shaan1337 approved these changes

Assignees

@thefringeninja thefringeninja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thefringeninja @pgermishuys @shaan1337