Tracing improvements #311
Merged
Tracing improvements #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion being thrown in absence thereof
josephcummings
force-pushed
the
josephcummings/subscription-tracing-metadata-parsing-exception
branch
from
a769168
to
3bc302d
Compare
yreynhout
reviewed
Jun 6, 2024
src/EventStore.Client/Common/Diagnostics/EventMetadataExtensions.cs
Outdated
Show resolved
Hide resolved
w1am
previously approved these changes
Jun 6, 2024
…ve diagnostic listeners
josephcummings
force-pushed
the
josephcummings/subscription-tracing-metadata-parsing-exception
branch
from
619d2a2
to
d25dd9c
Compare
josephcummings
changed the title
RagingKore
approved these changes
Jun 6, 2024
w1am
approved these changes
Jun 6, 2024
yreynhout
reviewed
Jun 6, 2024
src/EventStore.Client/Common/Diagnostics/EventMetadataExtensions.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Use TryParseValue when attempting to parse event metadata as JsonDocument, to prevent unneccessary exception with catch.
Changed: Use TryGetProperty when extracting tracing metadata to prevent unneccessary exception being thrown in absence thereof.
Changed: Added short-circuit to tracing logic to prevent unnecessary parsing of event data et al when there are no diagnostic listeners.
Fixes #310