Added 3 overloads of AddEventStoreClient
#238
Conversation
These new methods provide access to the `IServiceProvider`, allowing easy configuration across environments. This is very useful when using EventStore on different environments, that use different EventStores. I currently have this code running in production, and it works very well in combination with a configuration manager such as Azure App Configuration, or Azure Key Vault. They allow constructing the following using the ServiceProvider: - Uri address - string connectionString - Action<EventStoreClientSettings` configureSettings I've also added: - 2 new private methods that do the actual registration - tests for all 3 public methods
|
I submitted a fix for the Client development project automations for pull requests test failure: EventStore/Automations#70 😊 |
|
The PR linked above has been merged, so |
test/EventStore.Client.Streams.Tests/DependencyInjectionTests.cs
Outdated
Show resolved
Hide resolved
Also renamed tests to be more human-readable
This fixes publish failing with the error `error NETSDK1194: The "--output" option isn't supported when building a solution.` The `--output` flag has been deprecated, the recommended approach is to use `/p:PublishDir=..` instead. Reference: dotnet/performance#2774
|
The publish workflow failed, commit 5f606de in this PR ought to fix it though :) |
|
Both tests seem to fail because If you'd like I could remove |
That would be great! |
|
@NielsPilgaard we'll remove net5 in a separate PR |
|
Alrighty 👍 I wouldn't mind making that PR either, but I totally understand if you'd prefer a change like that to be made in-house. |
|
I've committed a fix for my newest pipeline bug 😅 the |
Hi there 👋
This PR adds 3 new overloads of
AddEventStoreClientthat provide access to theIServiceProvider, allowing easy configuration across environments. This is very useful when using EventStore on different environments, that use different EventStores.They allow constructing the following using the ServiceProvider:
I've also added:
I currently have one of these extension methods running in production, and it works very well in combination with a configuration manager such as Azure App Configuration, or Azure Key Vault.