Dispose the gRPC call underlying a Read if the read is only partially consumed #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefringeninja
previously approved these changes
Dec 9, 2022
… consumed e.g. when early returning from an await foreach or calling .First(). The IAsyncEnumerable is disposed as before, but now that causes the cancellation of the ResponseStream read, so PumpMessages completes and the call is disposed. The CancellationTokenSource need not be disposed because it is always cancelled (That is, as long as the user makes any attempt to consume the read - if they don't then the call remains open as before)
timothycoleman
force-pushed
the
dispose-partially-consumed-reads
branch
from
89233b8
to
0acc029
Compare
|
Made the same fix for $all reads - thanks @pvanbuijtene for pointing it out |
pvanbuijtene
approved these changes
Dec 12, 2022
thefringeninja
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Dispose the gRPC call underlying a Read if the read is only partially consumed
e.g. when early returning from an await foreach or calling .First().
The IAsyncEnumerable is disposed as before, but now that causes the cancellation of the ResponseStream read, so PumpMessages completes and the call is disposed.
The CancellationTokenSource need not be disposed because it is always cancelled (That is, as long as the user makes any attempt to consume the read - if they don't then the call remains open as before)
Note, I did attempt to remove the channel, but the ReadState task is populated proactively, without the user needing to start consuming the read, so simply having IAsyncEnumerables isn't so straight forward.
Fixes: #219