-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce New Types For Subscription Positions #188
Introduce New Types For Subscription Positions #188
Conversation
e01ee93
to
be69669
Compare
be69669
to
4c21e46
Compare
4c21e46
to
7c16de9
Compare
fc6a829
to
91e2e7f
Compare
91e2e7f
to
b860e77
Compare
b860e77
to
04ad5e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hold off for the sec, still reviewing
93ff2dd
93ff2dd
to
2273a1e
Compare
2273a1e
to
010f3ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Added: New Types for Subscription Positions
Having an if statement to call one of two overloads when trying to subscribe has proved cumbersome. Adding two new types,
FromAll
andFromStream
, should make it easier for consumers.Fixes: #186