Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default Keep Alive #107

Merged
merged 5 commits into from
Feb 22, 2021
Merged

Conversation

thefringeninja
Copy link
Contributor

No description provided.

@thefringeninja thefringeninja self-assigned this Feb 10, 2021
settings.ConnectivitySettings.KeepAliveInterval = keepAliveIntervalMs switch {
int value when value == -1 => Timeout.InfiniteTimeSpan,
int value when value >= 0 => TimeSpan.FromMilliseconds(value),
_ => throw new InvalidSettingException($"Invalid KeepAliveInterval: {keepAliveIntervalMs}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Minor, but in RFC is a bit different format: $"Invalid keepAliveInterval {keepAliveInterval}. Please provide a positive integer, or -1 to disable.".
Same comment for code below https://github.com/EventStore/EventStore-Client-Dotnet/pull/107/files#diff-29e93df819e6a1e3940a362a23ca7857372b6098e23b26c18f4f61282c6319bfR184.

@hayley-jean hayley-jean merged commit a853663 into EventStore:master Feb 22, 2021
@thefringeninja thefringeninja deleted the keep-alive branch June 28, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants