[fix] Added missing origin property. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,7 +186,8 @@ function EventSource(url, eventSourceInitDict) { | |||
| var type = eventName || 'message'; | |||
| _emit(type, new MessageEvent(type, { | |||
| data: data.slice(0, -1), // remove trailing newline | |||
| lastEventId: lastEventId | |||
| lastEventId: lastEventId, | |||
| origin: original(url) | |||
There was a problem hiding this comment.
Would you be open to providing an inline definition of original? The lib has 0 dependencies, which I think has some benefits - I'd like to keep it that way.
There was a problem hiding this comment.
Sure we can bundle it with a license reference in the file but that kinda defeats the purpose of having dependencies. Because dependencies can be tested easily individually, maintained individually and shared with the community. If there would be fixes for the original module they will not make their way back to this module. But if you would rather scarifies this for the sake of no modules, i'm fine with that and i'll update the pull request if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Also moved the
require(url).parseout of the construction phase. It's a pointless performance hit and the require should be cached.