Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made message properties enumerable (they are now shown by console.log). #37

Merged
merged 2 commits into from
Sep 17, 2014
Merged

Conversation

goloroden
Copy link
Contributor

We had a problem with the following code:

eventSource.onmessage = function (e) {
  console.log(e);
};

This has always shown an empty object. The solution was to make the object's properties enumerable.

@aslakhellesoy
Copy link
Contributor

Awesome. Can you add a test please?

@mattwagl
Copy link

Added a test. Wasn't sure where to put it so I've appended it to the Events section. Hope this helps…

@aslakhellesoy aslakhellesoy merged commit f182410 into EventSource:master Sep 17, 2014
aslakhellesoy added a commit that referenced this pull request Sep 17, 2014
@aslakhellesoy
Copy link
Contributor

Thanks! v0.1.3 released with your fix.

@goloroden
Copy link
Contributor Author

Awesome, thanks a lot :-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants