Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add id to message. #28

Merged
merged 4 commits into from
Nov 21, 2013
Merged

Add id to message. #28

merged 4 commits into from
Nov 21, 2013

Conversation

mbieser
Copy link

@mbieser mbieser commented Oct 25, 2013

No description provided.

@aslakhellesoy
Copy link
Contributor

Thanks for the PR.

According to the spec (section 7, bullet 4) The id field in the message body should be exposed as lastEventId on the message object.

Moreover, if a message body does not carry an id, the message object's lastEventId field should be set to the last id.

To comply with the spec, you should pass lastEventId to the MessageEvent constructor and always define the lastEventId getter.

Can you fix this please?

@mbieser
Copy link
Author

mbieser commented Oct 28, 2013

Fixed. Let me know if you have any concerns.

@aslakhellesoy
Copy link
Contributor

Thanks! I'll let you know when I get a chance to take a closer look.

aslakhellesoy added a commit that referenced this pull request Nov 21, 2013
@aslakhellesoy
Made MessageEvent more spec compliant. Attibution for #28.
c87be41
@aslakhellesoy aslakhellesoy merged commit e93f42f into EventSource:master Nov 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbieser @aslakhellesoy