Improve Arabic & convert to arabic numbers #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does |
|
@EvanHahnI have updated CSV and now all tests passed. |
|
Thanks! I'll take a look soon. |
Closed
|
Thanks! I am going to make some changes in #199 and will merge soon. |
EvanHahn
pushed a commit
that referenced
this pull request
Jun 6, 2021
Co-authored-by: Evan Hahn <[email protected]> See [#198][0] and [#199][1]. [0]: #198 [1]: #199
|
This has been deployed in I would like to add you to the contributors list. What name and URL should I use? |
|
Thanks a lot for your work.
I will be honored to become a contributor.
You can use the GitHub link https://github.com/Misioka
And my name is Michal Karzel
…On Sun, Jun 6, 2021, 21:18 Evan Hahn ***@***.***> wrote:
This has been deployed in ***@***.*** Thanks again!
I would like to add you to the contributors list. What name and URL should
I use?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#198 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6VALJ4O26Z7UQXIGUIZF3TRPCXBANCNFSM45TCFO6A>
.
|
|
I just credited you in 8e03ec0. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases like e.g. react-native Number.toLocaleString is not working. That's why I have added the convert function to the dictionary.